Repository navigation
packaging: guided set-up, with the choice of the contract executor - #131
Merged
Merged
Conversation
…onfiguration of a node
…onfig.ini accept it Many operators upgrade an official folder by copying only the node binary: the old executor stays, and an executor whose build is outside executor_commit_min..max of config.ini is stopped by the node, which then runs no smart contract (the official config.ini accepts 1518 only, a community executor counts higher). When config.ini runs an executor, the set-up (setup.sh and setup.ps1) now shows the build of the jars in the folder (from their git.properties: unzip, python3 or the JDK's jar tool) and the range config.ini accepts, and asks: community (the latest community build) or official (1518). When the jars in the folder are not the chosen kind it offers to download them, the community ones from the latest EnzinoBB/contract-executor release (checked against its SHA256SUMS), the official ones out of the CREDITSCOM release package (checked against their known SHA-256); the replaced jars are kept aside (.official, put back by a later choice of the official executor without a download, or .bak-<date>). Then it widens executor_commit_min/max to the build in place. Declined or failed, it says what to copy where. Unattended (--defaults) nothing is downloaded. Every run ends with what to copy when the folder is updated later: node, contract-executor.jar and sc-api-support.jar together. README-COMMUNITY.txt explains the upgrade of an existing folder; setup-test.yml answers the new question and checks a folder that kept the official range and one without the jars.
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contains the guided set-up of
feat/setup-script(3f2a96c, not yet on master) and adds the choice of the contract executor to it.Why. Many operators upgrade an official folder by copying only the
nodebinary. The old executor stays. More importantly, the node starts an executor only if the build it reports (its git commit count) is withinexecutor_commit_min..executor_commit_maxofconfig.ini, and stops it otherwise: the node then runs no smart contract (as a confidant it fails every contract execution, getters through its API fail). The officialconfig.iniaccepts 1518 only; a community executor counts higher (1543 today). The build number is a local check only: it never reaches the network, and both executors give the same contract results, so either one is compatible with the official nodes.What the set-up does now (
setup.sh, andsetup.ps1behindsetup.bat), whenconfig.inihas anexecutor_command:git.propertieswithunzip,python3or the JDK'sjartool; PowerShell:System.IO.Compression) and the rangeconfig.iniaccepts, warns whencontract-executor.jarandsc-api-support.jarcome from different builds, and asks community (the latest community build) or official (1518). Enter keeps the kind in the folder;EnzinoBB/contract-executorrelease, checked against itsSHA256SUMS; the official ones out of the CREDITSCOM release package (about 350 MB streamed, only the two jars kept), checked against their known SHA-256. The replaced jars are kept aside: as.officialwhen they are the official ones (choosing official later puts them back without a download), otherwise as.bak-<date>;executor_commit_min/executor_commit_maxin[api]to the build in place, and says so;--defaults) nothing is downloaded;node,contract-executor.jarandsc-api-support.jartogether, then run the set-up again.README-COMMUNITY.txtexplains how to upgrade an existing folder (an official one too).setup-test.ymlanswers the new question in its runs and adds a step: a folder that kept the official range (the set-up raisesexecutor_commit_maxto the package's build), then the same folder without the jars (downloaded from GitHub and checked), on Linux, Windows and macOS.API and packaging only: nothing in the node changes.
Test plan
setup.sh: community → downloaded build 1543, official jars kept as.official,executor_commit_max=1543; again with official →.officialput back;--defaultskeeps the jars; a folder with community jars and no backup, official → downloaded from the CREDITSCOM release, SHA-256 equal to the release's (18 s)jar_buildwith neitherunzipnorpython3on thePATH: read with the JDK'sjartoolsetup.ps1under PowerShell 7.4 (Linux,curl.exe/tar.exeshims): community download, restore of.official, official download,[api]keys updated in the writtenconfig.inisetup-test.ymlstep replayed locally on the community.14 Linux packagesetup-test.ymlon the branch (Linux, Windows, macOS)🤖 Generated with Claude Code